Comments on: Architechtural Atrocities, part 1 http://blog.iconara.net/2006/02/10/architechtural-atrocities-part-1/ Tue, 31 Aug 2010 16:51:34 +0000 hourly 1 http://wordpress.org/?v=3.0 By: Theo http://blog.iconara.net/2006/02/10/architechtural-atrocities-part-1/comment-page-1/#comment-7812 Theo Fri, 24 Apr 2009 12:13:58 +0000 http://blog.iconara.net/?p=9#comment-7812 <p>The point is that the source bitmap is the receiving object, so to apply filters to <code>bitmap1</code> you write <code>bitmap1.applyFilters(bitmap1, ...)</code>.</p> <p>Now, the docs say that you can pass another bitmap as the source, but that should have been a separate method. The common case it to apply the filters to the receiving object, so that should be what the method does. Then there could be a <code>applyFiltersWithSource</code> (or whatever) that accepted a separate source bitmap. The architectural atrocity is that the designers of the <code>BitmapData</code> class thought it was a good idea to mix these two together, so that in the common case you have a procedural-style object function where the first argument is the <code>this</code> object.</p> The point is that the source bitmap is the receiving object, so to apply filters to bitmap1 you write bitmap1.applyFilters(bitmap1, ...).

Now, the docs say that you can pass another bitmap as the source, but that should have been a separate method. The common case it to apply the filters to the receiving object, so that should be what the method does. Then there could be a applyFiltersWithSource (or whatever) that accepted a separate source bitmap. The architectural atrocity is that the designers of the BitmapData class thought it was a good idea to mix these two together, so that in the common case you have a procedural-style object function where the first argument is the this object.

]]> By: Alexander Arendar http://blog.iconara.net/2006/02/10/architechtural-atrocities-part-1/comment-page-1/#comment-7810 Alexander Arendar Fri, 24 Apr 2009 09:11:38 +0000 http://blog.iconara.net/?p=9#comment-7810 <p>Dude,</p> <p>I agree with your point that returning a number is very funny thing and exceptions should work much better. But regarding the first point on sourceBitmap argument... Could you provide your alternative of how the method signature would look like in ideal world? Anyway you need to pass the source bitmap as one of the arguments so seems having it named "sourceBitmap" is not that bad, better than param1 I think :)</p> Dude,

I agree with your point that returning a number is very funny thing and exceptions should work much better. But regarding the first point on sourceBitmap argument… Could you provide your alternative of how the method signature would look like in ideal world? Anyway you need to pass the source bitmap as one of the arguments so seems having it named “sourceBitmap” is not that bad, better than param1 I think :)

]]>